Fix and improve project docstrings#170
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
llucax
June 29, 2026 13:21
View session
github-actions
Bot
added
part:tooling
llucax
added
the
cmd:skip-release-notes
llucax
force-pushed
the
copilot/check-fix-improve-docstrings
branch
from
7e3df90 to
2f0043c
Compare
llucax
force-pushed
the
copilot/check-fix-improve-docstrings
branch
2 times, most recently
from
06eab6a to
7f9e2f5
Compare
llucax
requested review from
a team and
daniel-zullo-frequenz
and removed request for
a team
Contributor
|
Super weird that this is failing the build step, it didn't fail in other PRs and this PR only touches docstrings (and config files parts that should not be involved in package building at all). 🤔 😒 |
|
It could be related to setuptools_scm, updating it to the latest version might solve this problem |
daniel-zullo-frequenz
approved these changes
Jun 30, 2026
Contributor
|
It would be weird, but possible if it is a cache thing, because many dependabot PRs were created and merged after this PR was created. |
Add missing pydoclint options to `[tool.flake8]` in `pyproject.toml`: - `check-class-attributes = true` - `check-style-mismatch = true` - `require-inline-class-var-docs = true` - `skip-checking-short-docstrings = true` Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Add `relative_crossrefs: true` to `mkdocs.yml` `mkdocstrings` options. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
- `Interval` class: fix typo "limites" → "limits", add cross-references for `.start` and `.end` attributes in the class body docstring - `Interval.__contains__`: move summary to the opening line, remove type hint from the `Returns:` section (DOC111 equivalent) Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
- Module docstring: correct the `Note:` admonition that incorrectly stated a `ValueError` would be raised for duplicate `str_prefix` registrations; the code only logs a warning - `BaseId.__eq__`, `__lt__`: add missing `Args:` and `Returns:` sections - `BaseId.__hash__`: add missing `Returns:` section Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
- `DeprecatingEnumType.__new__`: add cross-reference for `DeprecatedMember` - `DeprecatingEnumType` class docstring: add cross-references for `DeprecatedMember` and `deprecated_member()` in the Behavior block Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Fix typo `metaclas` → `metaclass` in `NoInitConstructibleMeta` docstring example. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
force-pushed
the
copilot/check-fix-improve-docstrings
branch
from
7f9e2f5 to
3016f80
Compare
Contributor
|
At the end you were right. I rebased on top of the merged dependabot bumps and that fixed it, probably depeandbot upgraded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sweep of docstring violations and missing tooling configuration per Frequenz Python docstring conventions.